Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More than one contactInfo for responsible party display issues/indexing errors #87

Open
jonescc opened this issue Aug 28, 2020 · 1 comment
Open

More than one contactInfo for responsible party display issues/indexing errors #87

jonescc opened this issue Aug 28, 2020 · 1 comment

Comments

@jonescc
Copy link
Member

jonescc commented Aug 28, 2020 •
edited
Loading

Records we harvest from CSIRO who are also using 19115-3:2018 include two contactInfo elements for an organisation. One containing the postal address of the organisation and one containing the street address. Some details such as phone numbers and websites are duplicated in each contactInfo element (see xml fragment below) although this does not necessarily need to be the case.

We can't currently view these records in the default view as indexing can't currently handle multiple websites for a responsible party.

However, if I modify indexing to index just the first website, then there are display issues as well:

image

Would be good if we could at least index the records. We'd also be happy just to display the first contactInfo section for a party until the code (which looks to have been written for 19139 which is far less flexible) can be reworked to handle multiple contactInfos, web sites, etc. I'll put up a pull request for that if that's considered suitable.

         <mri:pointOfContact>
            <cit:CI_Responsibility>
               <cit:role>
                  <cit:CI_RoleCode codeList="http://schemas.aodn.org.au/mcp-2.0/schema/resources/Codelist/gmxCodelists.xml#CI_RoleCode"
                                   codeListValue="pointOfContact">pointOfContact</cit:CI_RoleCode>
               </cit:role>
               <cit:party>
                  <cit:CI_Organisation xsi:schemaLocation="http://standards.iso.org/iso/19115/-3/mds/2.0 http://standards.iso.org/iso/19115/-3/mds/2.0/mds.xsd">
                     <cit:name>
                        <gco:CharacterString xsi:schemaLocation="http://standards.iso.org/iso/19115/-3/mds/2.0 http://standards.iso.org/iso/19115/-3/mds/2.0/mds.xsd">CSIRO Oceans &amp; Atmosphere - Hobart</gco:CharacterString>
                     </cit:name>
                     <cit:contactInfo>
                        <cit:CI_Contact xsi:schemaLocation="http://standards.iso.org/iso/19115/-3/mds/2.0 http://standards.iso.org/iso/19115/-3/mds/2.0/mds.xsd">
                           <cit:phone>
                              <cit:CI_Telephone>
                                 <cit:number>
                                    <gco:CharacterString>+61 3 6232 5222</gco:CharacterString>
                                 </cit:number>
                                 <cit:numberType>
                                    <cit:CI_TelephoneTypeCode codeList="http://standards.iso.org/iso/19115/resources/Codelist/cat/codelists.xml#CI_RoleCode"
                                                              codeListValue="voice"/>
                                 </cit:numberType>
                              </cit:CI_Telephone>
                           </cit:phone>
                           <cit:phone>
                              <cit:CI_Telephone>
                                 <cit:number>
                                    <gco:CharacterString>+61 3 6232 5000</gco:CharacterString>
                                 </cit:number>
                                 <cit:numberType>
                                    <cit:CI_TelephoneTypeCode codeList="http://standards.iso.org/iso/19115/resources/Codelist/cat/codelists.xml#CI_RoleCode"
                                                              codeListValue="facsimile"/>
                                 </cit:numberType>
                              </cit:CI_Telephone>
                           </cit:phone>
                           <cit:address>
                              <cit:CI_Address>
                                 <cit:deliveryPoint>
                                    <gco:CharacterString>GPO Box 1538</gco:CharacterString>
                                 </cit:deliveryPoint>
                                 <cit:city>
                                    <gco:CharacterString>Hobart</gco:CharacterString>
                                 </cit:city>
                                 <cit:administrativeArea>
                                    <gco:CharacterString>TAS</gco:CharacterString>
                                 </cit:administrativeArea>
                                 <cit:postalCode>
                                    <gco:CharacterString>7001</gco:CharacterString>
                                 </cit:postalCode>
                                 <cit:country>
                                    <gco:CharacterString>Australia</gco:CharacterString>
                                 </cit:country>
                                 <cit:electronicMailAddress gco:nilReason="missing">
                                    <gco:CharacterString/>
                                 </cit:electronicMailAddress>
                              </cit:CI_Address>
                           </cit:address>
                           <cit:onlineResource>
                              <cit:CI_OnlineResource>
                                 <cit:linkage>
                                    <gco:CharacterString>http://www.csiro.au/en/Research/OandA</gco:CharacterString>
                                 </cit:linkage>
                                 <cit:protocol>
                                    <gco:CharacterString>WWW:LINK-1.0-http--link</gco:CharacterString>
                                 </cit:protocol>
                                 <cit:description>
                                    <gco:CharacterString>Web address for organisation CSIRO Oceans &amp; Atmosphere - Hobart</gco:CharacterString>
                                 </cit:description>
                              </cit:CI_OnlineResource>
                           </cit:onlineResource>
                        </cit:CI_Contact>
                     </cit:contactInfo>
                     <cit:contactInfo>
                        <cit:CI_Contact xsi:schemaLocation="http://standards.iso.org/iso/19115/-3/mds/2.0 http://standards.iso.org/iso/19115/-3/mds/2.0/mds.xsd">
                           <cit:phone>
                              <cit:CI_Telephone>
                                 <cit:number>
                                    <gco:CharacterString>+61 3 6232 5222</gco:CharacterString>
                                 </cit:number>
                                 <cit:numberType>
                                    <cit:CI_TelephoneTypeCode codeList="http://standards.iso.org/iso/19115/resources/Codelist/cat/codelists.xml#CI_RoleCode"
                                                              codeListValue="voice"/>
                                 </cit:numberType>
                              </cit:CI_Telephone>
                           </cit:phone>
                           <cit:phone>
                              <cit:CI_Telephone>
                                 <cit:number>
                                    <gco:CharacterString>+61 3 6232 5000</gco:CharacterString>
                                 </cit:number>
                                 <cit:numberType>
                                    <cit:CI_TelephoneTypeCode codeList="http://standards.iso.org/iso/19115/resources/Codelist/cat/codelists.xml#CI_RoleCode"
                                                              codeListValue="facsimile"/>
                                 </cit:numberType>
                              </cit:CI_Telephone>
                           </cit:phone>
                           <cit:address>
                              <cit:CI_Address>
                                 <cit:deliveryPoint>
                                    <gco:CharacterString>Castray Esplanade</gco:CharacterString>
                                 </cit:deliveryPoint>
                                 <cit:city>
                                    <gco:CharacterString>Hobart</gco:CharacterString>
                                 </cit:city>
                                 <cit:administrativeArea>
                                    <gco:CharacterString>TAS</gco:CharacterString>
                                 </cit:administrativeArea>
                                 <cit:postalCode>
                                    <gco:CharacterString>7000</gco:CharacterString>
                                 </cit:postalCode>
                                 <cit:country>
                                    <gco:CharacterString>Australia</gco:CharacterString>
                                 </cit:country>
                                 <cit:electronicMailAddress gco:nilReason="missing">
                                    <gco:CharacterString/>
                                 </cit:electronicMailAddress>
                              </cit:CI_Address>
                           </cit:address>
                           <cit:onlineResource>
                              <cit:CI_OnlineResource>
                                 <cit:linkage>
                                    <gco:CharacterString>http://www.csiro.au/en/Research/OandA</gco:CharacterString>
                                 </cit:linkage>
                                 <cit:protocol>
                                    <gco:CharacterString>WWW:LINK-1.0-http--link</gco:CharacterString>
                                 </cit:protocol>
                                 <cit:description>
                                    <gco:CharacterString>Web address for organisation CSIRO Oceans &amp; Atmosphere - Hobart</gco:CharacterString>
                                 </cit:description>
                              </cit:CI_OnlineResource>
                           </cit:onlineResource>
                        </cit:CI_Contact>
                     </cit:contactInfo>
                     <cit:individual>
                        <cit:CI_Individual>
                           <cit:name>
                              <gco:CharacterString>CSIRO O&amp;A, Information &amp; Data Centre</gco:CharacterString>
                           </cit:name>
                           <cit:contactInfo>
                              <cit:CI_Contact>
                                 <cit:address>
                                    <cit:CI_Address>
                                       <cit:electronicMailAddress>
                                          <gco:CharacterString>[email protected]</gco:CharacterString>
                                       </cit:electronicMailAddress>
                                    </cit:CI_Address>
                                 </cit:address>
                              </cit:CI_Contact>
                           </cit:contactInfo>
                           <cit:positionName>
                              <gco:CharacterString>Data Requests</gco:CharacterString>
                           </cit:positionName>
                        </cit:CI_Individual>
                     </cit:individual>
                  </cit:CI_Organisation>
               </cit:party>
            </cit:CI_Responsibility>
         </mri:pointOfContact>
@jonescc
Copy link
Member Author

jonescc commented Aug 28, 2020

@sppigot FYI

fxprunayre pushed a commit that referenced this issue Sep 3, 2020
@jonescc @fxprunayre
Addresses #87 - Only include details from the first contactInfo
d15dbf3 
element when indexing responsible party's to more align with the way 19139 records are indexed until
until gmMetadataContact is reworked to handle 19115-3:2018 responsible parties
Difficult to handle all possible combinations until that rework is done.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jonescc