Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard 'id' will still add 'id' on update #357

Open
FricoRico opened this issue Nov 13, 2020 · 1 comment
Open

Guard 'id' will still add 'id' on update #357

FricoRico opened this issue Nov 13, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@FricoRico
Copy link

Hi Luca! Thanks for your development and commitment to vuex-easy-firestore.

As pointed out in another ticket (#83) some fields are automatically when patching data. You've implemented guards and fillables to have more control over this behaviour.

I've added guard: ['id', 'updated_at', 'updated_by'] to my modules. Indeed upon updating the updated_at and updated_by will no longer be added. But it seems id is still added by default. Is this a bug?

@louisameline
Copy link
Collaborator

Hello, that's how it works for now, as the id is used somewhere at some point. I managed to change this in a fork though, it wasn't too hard.

@louisameline louisameline added the enhancement New feature or request label Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants