Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update GitHub Actions #279

Open
Hunter275 opened this issue Aug 26, 2024 · 2 comments
Open

Update GitHub Actions #279

Hunter275 opened this issue Aug 26, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed meta Unrelated to the web app specifically minor change This is a minor change ongoing Long lived issue

Comments

@Hunter275
Copy link
Member

We need to update the GitHub actions now that the repo is getting more active, we shouldn't be publishing PRs and the likes.
@Hunter275 Hunter275 added enhancement New feature or request help wanted Extra attention is needed minor change This is a minor change meta Unrelated to the web app specifically labels Aug 26, 2024
@TheCyberRonin
Copy link
Contributor

May I suggest that you change the scope of the CI workflow? You should be able to target a merge into master branch. That way anything that actually gets added would be considered "a release". I'd also maybe add a develop branch that is a "container" for work that isn't quite ready for a release and be a staging area for a release.

@TheCyberRonin
Copy link
Contributor

#287 Should address the CI workflow (building and doing a release) running on PRs. After that PR is accepted/merged, it will be in effect.

After that is merged, the CI GitHub Action will only run when a push to master is made. (A PR merge counts as a push)

@Hunter275 Hunter275 added the ongoing Long lived issue label Sep 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request help wanted Extra attention is needed meta Unrelated to the web app specifically minor change This is a minor change ongoing Long lived issue
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Hunter275 @TheCyberRonin