Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add ability to enable/disable HTTPS connections #250

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

add ability to enable/disable HTTPS connections #250

wants to merge 2 commits into from

Conversation

Hunter275
Copy link
Member

Closes #249

@Hunter275 Hunter275 added bug Something isn't working minor change This is a minor change labels Jun 21, 2024
@Hunter275 Hunter275 marked this pull request as draft June 21, 2024 19:33
@Hunter275
Copy link
Member Author

Not ready, will delete this when ready

@bmv437
Copy link
Contributor

bmv437 commented Jun 22, 2024

Issue: Browsers block mixed content, which is when secure HTTPS pages call insecure HTTP urls. Because of this you'll need to add logic to:

  • Set the initial/default states based on location.protocol === 'https:'.
  • Disable the <Switch> if location.protocol === 'https:'.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working minor change This is a minor change
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Device blocked by CORS policy
2 participants
@Hunter275 @bmv437