Skip to content

Commit

Permalink
remove deprecated serial/bt logging options and unify in the new
Browse files Browse the repository at this point in the history
security option.  Per discussion in meshtastic/firmware#4375
no need to preserve the old options when changing to this new simpler
single boolean because they were newish, rarely used and only for 'advanced'
developers.
  • Loading branch information
geeksville committed Aug 20, 2024
1 parent 56a4355 commit 183ba97
Showing 1 changed file with 2 additions and 20 deletions.
22 changes: 2 additions & 20 deletions meshtastic/config.proto
Original file line number Diff line number Diff line change
Expand Up @@ -139,13 +139,6 @@ message Config {
*/
bool serial_enabled = 2[deprecated = true];

/*
* By default we turn off logging as soon as an API client connects (to keep shared serial link quiet).
* Set this to true to leave the debug log outputting even when API is active.
* Moved to SecurityConfig
*/
bool debug_log_enabled = 3[deprecated = true];

/*
* For boards without a hard wired button, this is the pin number that will be used
* Boards that have more than one button can swap the function with this one. defaults to BUTTON_PIN if defined.
Expand Down Expand Up @@ -1014,12 +1007,6 @@ message Config {
* Specified PIN for PairingMode.FixedPin
*/
uint32 fixed_pin = 3;

/*
* Enables device (serial style logs) over Bluetooth
* Moved to SecurityConfig
*/
bool device_logging_enabled = 4[deprecated = true];
}

message SecurityConfig {
Expand Down Expand Up @@ -1054,15 +1041,10 @@ message Config {

/*
* By default we turn off logging as soon as an API client connects (to keep shared serial link quiet).
* Output live debug logging over serial.
* Output live debug logging over serial or bluetooth is set to true.
*/
bool debug_log_api_enabled = 6;

/*
* Enables device (serial style logs) over Bluetooth
*/
bool bluetooth_logging_enabled = 7;

/*
* Allow incoming device control over the insecure legacy admin channel.
*/
Expand All @@ -1088,4 +1070,4 @@ message Config {
SecurityConfig security = 8;
SessionkeyConfig sessionkey = 9;
}
}
}

0 comments on commit 183ba97

Please sign in to comment.