Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update meshtastic-js to newer protobuf spec #97

Merged
merged 3 commits into from
Aug 24, 2024
Merged

Update meshtastic-js to newer protobuf spec #97

merged 3 commits into from
Aug 24, 2024

Conversation

johnlaur
Copy link
Contributor

Closes: #96

This PR bumps package versions; most importantly @buf/meshtastic_protobufs.bufbuild_es

The factory reset API has since been refactored into separate reset device and reset config instructions. I updated the function names to match which removes the previously available factoryReset() API. If there is a desire to maintain backwards compatibility, factoryReset() could be aliased to factoryResetDevice().

I have also not incremented the meshtastic-js version number as defined in package.json.

@CLAassistant
Copy link

CLAassistant commented Aug 20, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Hunter275
Copy link
Member

@johnlaur

Build error:
ERR_PNPM_OUTDATED_LOCKFILE  Cannot install with "frozen-lockfile" because pnpm-lock.yaml is not up to date with package.json

Please include the pnpm-lock.yaml file in your PR

@johnlaur
Copy link
Contributor Author

Sorry I am new to pnpm. I will figure that out and post a fix.

@Hunter275
Copy link
Member

Sorry I am new to pnpm. I will figure that out and post a fix.

No problem. You shouldn't need to do anything except commit that file to the branch.

@Hunter275 Hunter275 requested a review from sachaw August 24, 2024 02:53
@Hunter275 Hunter275 changed the base branch from master to protobufs-and-serialconsole August 24, 2024 03:10
@Hunter275 Hunter275 merged commit 05d6690 into meshtastic:protobufs-and-serialconsole Aug 24, 2024
3 checks passed
@johnlaur
Copy link
Contributor Author

Hey thank you for the merge and sorry for the delay; I was just able to get back to look at this today. I do have pnpm set up now.

@Hunter275 Hunter275 mentioned this pull request Aug 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thebentern thebentern Awaiting requested review from thebentern

@sachaw sachaw Awaiting requested review from sachaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Several interfaces are missing due to depending on old protobuf build
3 participants
@johnlaur @CLAassistant @Hunter275