Initiate magnetometer based compass calibration from button presses #5553
+71
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danwelch3
commented
Dec 12, 2024
danwelch3
commented
- only active for BMX160 accelerometers on RAK_4631
- replace automatic calibration on power on with button triggered calibration
- set 5 presses to trigger 30s calibration
- set 6 presses to trigger 60s calibration (useful if unit is not handheld, ie vehicle mounted)
- show calibration time remaining on calibration alert screen
|
Thanks for this! It looks like you may have checked in changes to the protobufs. These are automatically generated , so please update the patch not to include these :) |
- only active for BMX160 accelerometers on RAK_4631 - replace automatic calibration on power on with button triggered calibration - set 5 presses to trigger 30s calibration - set 6 presses to trigger 60s calibration (useful if unit is not handheld, ie vehicle mounted) - show calibration time remaining on calibration alert screen
- exclude changes from non RAK 4631 builds - remove calls to screen when not present
- exclude all compass heading updates on variant without screen
danwelch3
force-pushed
the
feature-button-calibrate
branch
from
2f7e479 to
686f569
Compare
|
Thanks for pointing that out. I think I successfully removed the changes to protobufs from the patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.