SimRadio: clean-up and emulate collisions #5487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Converted to draft for now, would probably be nice to be able to disable the emulation of collisions. |
thebentern
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up some of the guarding for the simulator. Actually all Portduino variants have
HAS_RADIOstill set to 0, but only when the SimRadio is actually initialized, we should handle the packets from the simulator.HAS_RADIOcan now thus be set to 1 for Portduino as well, and when it doesn’t have a radio configured, it will fall back to SimRadio.Also, the simulator can’t handle PKC packets, so this avoids using it when SimRadio is used.
Furthermore, SimRadio now emulates collisions when it receives a packet while it is currently sending or receiving another one. Those bad packets are now counted as well, and sent with the LocalStats.