Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GPS_DEBUG output #5100

Merged
merged 2 commits into from
Oct 20, 2024
Merged

Conversation

fifieldt
Copy link
Contributor

After the recent change to move logging line breaks to a central location, GPS_DEBUG is now emitting one character per line, making the logs unusable.

Patch uses local strings and appends to collate and then print in the right places.

Fixes #5099

fifieldt and others added 2 commits October 20, 2024 11:44
After the recent change to move logging line breaks to a central
location, GPS_DEBUG is now emitting one character per line,
making the logs unusable.

Patch uses local strings and appends to collate and then print
in the right places.

Fixes meshtastic#5099
@thebentern thebentern merged commit 2ba72c1 into meshtastic:master Oct 20, 2024
47 checks passed
panaceya added a commit to mesh-mk-ua/meshtastic-firmware that referenced this pull request Oct 21, 2024
* Add DIO2_AS_RF_SWITCH to pinedio prefilled config.

* Add `-p` flag (meshtastic#5093)

Add the `-p` to the `mkdir` so it doesn't fail when the folder already exists

Co-authored-by: Ben Meadors <[email protected]>

* Revert "Permanently engage !CTRL"

* Initial NODENUM_BROADCAST_NO_LORA implementation with NeighborInfo module (meshtastic#5087)

* Initial NODENUM_BROADCAST_NO_LORA implementation with NeighborInfo module

* isBroadcast

* Trunkt

* Move 115200 baud GNSS probe earlier (meshtastic#5101)

* Move 115200 baud GNSS probe earlier

* Even more optimized!

* Fix GPS_DEBUG output (meshtastic#5100)

After the recent change to move logging line breaks to a central
location, GPS_DEBUG is now emitting one character per line,
making the logs unusable.

Patch uses local strings and appends to collate and then print
in the right places.

Fixes meshtastic#5099

Co-authored-by: Ben Meadors <[email protected]>

* Wide_Lora uses 12 symbols to be compatible with SX1280

* Fix rebroadcasting encrypted packets when `KNOWN_ONLY` or `LOCAL_ONLY` is used (meshtastic#5109)

---------

Co-authored-by: Jonathan Bennett <[email protected]>
Co-authored-by: madeofstown <[email protected]>
Co-authored-by: Ben Meadors <[email protected]>
Co-authored-by: Thomas Göttgens <[email protected]>
Co-authored-by: Tom Fifield <[email protected]>
Co-authored-by: GUVWAF <[email protected]>
@fifieldt fifieldt deleted the fix-gps-linebreaks branch October 24, 2024 04:56
caveman99 pushed a commit that referenced this pull request Nov 3, 2024
After the recent change to move logging line breaks to a central
location, GPS_DEBUG is now emitting one character per line,
making the logs unusable.

Patch uses local strings and appends to collate and then print
in the right places.

Fixes #5099

Co-authored-by: Ben Meadors <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: GPS_DEBUG emits one character per line
2 participants