Only accept PKI messages for MQTT downlink for known nodes #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thebentern
approved these changes
Aug 18, 2024
|
Seems like a good idea. Most of these would get zero-hopped on the default broker anyway, so we'd only be dealing with private channels or a private broker instance. |
True, but still it lowers the processing effort of the node :) |
|
My only hesitation here is the case where one or both nodes have rolled out of the nodeDB, on a busy mesh. |
jp-bennett
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're potentially receiving a lot of DMs on an MQTT root topic if we have downlink enabled on a (private) channel, but not all are of interest. Let's only accept PKI messages when we know the transmitter and receiver, as then it's (more) likely they would normally have communicated via a channel we have downlink enabled.