Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Routing of messages of unknown channels in LOCAL_ONLY mode. #5106

Closed
CamFlyerCH opened this issue Oct 20, 2024 · 2 comments · Fixed by #5109
Closed

[Bug]: Routing of messages of unknown channels in LOCAL_ONLY mode. #5106

CamFlyerCH opened this issue Oct 20, 2024 · 2 comments · Fixed by #5109
Labels
bug Something isn't working

Comments

@CamFlyerCH
Copy link

Category

Other

Hardware

Heltec V3

Firmware Version

2.5.8.4575352d8

Description

While monitoring my node in client or router mode with CLI "meshtastic --noproto", i found that messages from other channels don't get dropped besides the rebroadcast mode is set to LOCAL_ONLY. I think this should not be done and it is a bug. Example below.

Relevant log output

DEBUG | 11:02:01 510 [RadioIf] Lora RX (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=2 Ch=0x2a encrypted rxSNR=-10 rxRSSI=-116 hopStart=3)
DEBUG | 11:02:01 510 [RadioIf] Packet received : 542ms
DEBUG | 11:02:01 510 [Router] Add packet record (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=2 Ch=0x2a encrypted rxSNR=-10 rxRSSI=-116 hopStart=3)
WARN  | 11:02:01 510 [Router] No suitable channel found for decoding, hash was 0x2a!
DEBUG | 11:02:01 510 [Router] packet decoding failed or skipped (no PSK?) (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=2 Ch=0x2a encrypted rxtime=1729422121 rxSNR=-10 rxRSSI=-116 hopS
DEBUG | 11:02:01 510 [Router] Module 'routing' wantsPacket=1
INFO  | 11:02:01 510 [Router] Received routing from=0xda585fa8, id=0x27ce8c95, portnum=-1054474215, payloadlen=62999
DEBUG | 11:02:01 510 [Router] Routing sniffing (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=2 Ch=0x2a encrypted rxtime=1729422121 rxSNR=-10 rxRSSI=-116 hopStart=3)
INFO  | 11:02:01 510 [Router] Rebroadcasting received floodmsg
DEBUG | 11:02:01 511 [Router] enqueuing for send (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=1 Ch=0x2a encrypted rxtime=1729422121 rxSNR=-10 rxRSSI=-116 hopStart=3 priority=64)
DEBUG | 11:02:01 511 [Router] txGood=19,txRelay=15,rxGood=53,rxBad=11
DEBUG | 11:02:01 511 [Router] rx_snr found. hop_limit:1 rx_snr:-10.000000
DEBUG | 11:02:01 511 [Router] rx_snr found in packet. As a router, setting tx delay:385
DEBUG | 11:02:01 511 [Router] Module 'routing' considered
WARN  | 11:02:01 511 [RadioIf] Can not send yet, busyRx
DEBUG | 11:02:01 511 [RadioIf] rx_snr found. hop_limit:1 rx_snr:-10.000000
DEBUG | 11:02:02 511 [RadioIf] rx_snr found in packet. As a router, setting tx delay:231
ERROR | 11:02:02 511 [RadioIf] ignoring received packet due to error=-7
DEBUG | 11:02:02 511 [RadioIf] Packet received (noise?) : 542ms
DEBUG | 11:02:02 511 [RadioIf] Starting low level send (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=1 Ch=0x2a encrypted rxtime=1729422121 rxSNR=-10 rxRSSI=-116 hopStart=3 priority=64)
DEBUG | 11:02:02 511 [RadioIf] Packet transmitted : 542ms
DEBUG | 11:02:02 512 [RadioIf] Completed sending (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=1 Ch=0x2a encrypted rxtime=1729422121 rxSNR=-10 rxRSSI=-116 hopStart=3 priority=64)
DEBUG | 11:02:03 512 [RadioIf] Lora RX (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=0 Ch=0x2a encrypted rxSNR=5.25 rxRSSI=-84 hopStart=3)
DEBUG | 11:02:03 512 [RadioIf] Packet received : 542ms
DEBUG | 11:02:03 512 [Router] Found existing packet record for fr=0xda585fa8,to=0xffffffff,id=0x27ce8c95
DEBUG | 11:02:03 512 [Router] Found existing packet record for fr=0xda585fa8,to=0xffffffff,id=0x27ce8c95
DEBUG | 11:02:03 512 [Router] Add packet record (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=0 Ch=0x2a encrypted rxSNR=5.25 rxRSSI=-84 hopStart=3)
DEBUG | 11:02:03 512 [Router] Ignoring dupe incoming msg (id=0x27ce8c95 fr=0xa8 to=0xff, WantAck=0, HopLim=0 Ch=0x2a encrypted rxSNR=5.25 rxRSSI=-84 hopStart=3)
DEBUG | 11:02:03 512 [Router] Incoming msg was filtered from 0xda585fa8
@GUVWAF
Copy link
Member

GUVWAF commented Oct 20, 2024

Thanks for reporting, this was working before, but broke with 2.5. It should work again after #5109.

@CamFlyerCH
Copy link
Author

I tested it and it is working !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants