Add heartbeat LED for HT-VME290 and HT-VME213 (#4511)

* Add heartbeat LED for HT-VME290 and HT-VME213 Not populated on original board, however revisions are now shipping which do have the LED * Update outdated commenting * Trunk strikes again
meshtastic · Aug 20, 2024 · 058e976 · 058e976
1 parent 3b2c37c
commit 058e976
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 4 deletions.
diff --git a/variants/heltec_vision_master_e213/pins_arduino.h b/variants/heltec_vision_master_e213/pins_arduino.h
@@ -3,8 +3,8 @@
 
 #include <stdint.h>
 
-static const uint8_t LED_BUILTIN = -1; // Board has no built-in LED, despite what schematic shows
-#define BUILTIN_LED LED_BUILTIN        // backward compatibility
+static const uint8_t LED_BUILTIN = 45; // LED is not populated on earliest board variant
+#define BUILTIN_LED LED_BUILTIN        // Backward compatibility
 #define LED_BUILTIN LED_BUILTIN
 
 static const uint8_t TX = 43;

diff --git a/variants/heltec_vision_master_e213/variant.h b/variants/heltec_vision_master_e213/variant.h
@@ -1,3 +1,4 @@
+#define LED_PIN 45 // LED is not populated on earliest board variant
 #define BUTTON_PIN 0
 #define BUTTON_PIN_SECONDARY 21         // Second built-in button
 #define BUTTON_SECONDARY_CANNEDMESSAGES // By default, use the secondary button as canned message input

diff --git a/variants/heltec_vision_master_e290/pins_arduino.h b/variants/heltec_vision_master_e290/pins_arduino.h
@@ -3,8 +3,8 @@
 
 #include <stdint.h>
 
-static const uint8_t LED_BUILTIN = -1;
-#define BUILTIN_LED LED_BUILTIN // backward compatibility
+static const uint8_t LED_BUILTIN = 45; // LED is not populated on earliest board variant
+#define BUILTIN_LED LED_BUILTIN        // Backward compatibility
 #define LED_BUILTIN LED_BUILTIN
 
 static const uint8_t TX = 43;

diff --git a/variants/heltec_vision_master_e290/variant.h b/variants/heltec_vision_master_e290/variant.h
@@ -1,3 +1,4 @@
+#define LED_PIN 45 // LED is not populated on earliest board variant
 #define BUTTON_PIN 0
 #define BUTTON_PIN_SECONDARY 21         // Second built-in button
 #define BUTTON_SECONDARY_CANNEDMESSAGES // By default, use the secondary button as canned message input