Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adapters] Evolve meshes.proto to adapters.proto #148

Closed
leecalcote opened this issue Jan 14, 2024 · 3 comments
Closed

[Adapters] Evolve meshes.proto to adapters.proto #148

leecalcote opened this issue Jan 14, 2024 · 3 comments
Assignees
Labels
area/lifecycle Lifecycle management (install, uninstall, configure) related area/performance Performance management issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature language/go Golang related
Milestone

Comments

@leecalcote
Copy link
Member

This issue is child issue (labeled with kind/child). See meshery/meshery#9966 for additional context.

Current Behavior

Meshery Adapters capabilities have progressed well beyond that of managing service meshes. Adapters include the ability to manage any type of structure as well as perform advanced performance management of that into structure.

Desired Behavior

The meshes.proto in Meshery Server is no longer representative of the broader set of capabilities that Meshery Adapters have. The name of this protobuf file and aspects of its internals need to be updated to reflect this fact.

Implementation

  1. Renaming meshes.proto to adapters.proto (and the directory name) - https://github.com/meshery/meshery-adapter-library/tree/master/meshes
  2. Update and remove any service mesh specific concepts in the proto and library to be infra and capability agnostic.

Resources

@leecalcote leecalcote added area/lifecycle Lifecycle management (install, uninstall, configure) related area/performance Performance management kind/enhancement Improvement in current feature language/go Golang related labels Jan 14, 2024
@leecalcote leecalcote added this to the v0.8.0 milestone Jan 14, 2024
@leecalcote
Copy link
Member Author

@MUzairS15 fyi

Copy link

stale bot commented Apr 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the issue/stale Issue has not had any activity for an extended period of time label Apr 13, 2024
Copy link

stale bot commented Apr 27, 2024

This issue is being automatically closed due to inactivity. However, you may choose to reopen this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/lifecycle Lifecycle management (install, uninstall, configure) related area/performance Performance management issue/stale Issue has not had any activity for an extended period of time kind/enhancement Improvement in current feature language/go Golang related
Projects
Development

No branches or pull requests

2 participants