Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Three golangci-lint check failures #26

Open
leecalcote opened this issue Sep 30, 2024 · 1 comment
Open

[Chore] Three golangci-lint check failures #26

leecalcote opened this issue Sep 30, 2024 · 1 comment
Labels
kind/bug Something isn't working kind/chore Necessary task language/go Golang related

Comments

@leecalcote
Copy link
Member

Current Behavior

A few golangci-lint checks are failing. See https://github.com/meshery/helm-kanvas-snapshot/actions/runs/11098994599/job/30832523474#step:4:26

Screenshots/Logs

run golangci-lint
  Running [/Users/runner/golangci-lint-1.59.1-darwin-arm64/golangci-lint run --path-prefix=./cmd/kanvas-snapshot --timeout 10m --verbose] in [/Users/runner/work/helm-kanvas-snapshot/helm-kanvas-snapshot/cmd/kanvas-snapshot] ...
  Error: cmd/kanvas-snapshot/main.go:178:13: Error return value of `io.ReadAll` is not checked (errcheck)
  		io.ReadAll(resp.Body)
  		          ^
  Error: cmd/kanvas-snapshot/main.go:254:44: Error return value of `generateKanvasSnapshotCmd.MarkFlagRequired` is not checked (errcheck)
  	generateKanvasSnapshotCmd.MarkFlagRequired("file")
  	                                          ^
  Error: cmd/kanvas-snapshot/main.go:255:44: Error return value of `generateKanvasSnapshotCmd.MarkFlagRequired` is not checked (errcheck)
  	generateKanvasSnapshotCmd.MarkFlagRequired("email")

Environment

  • Host OS: Mac Linux Windows
  • Platform: Docker or Kubernetes
  • Meshery Server Version: stable-v
  • Meshery Client Version: stable-v

Contributor Guides and Handbook

@leecalcote leecalcote added kind/bug Something isn't working kind/chore Necessary task language/go Golang related labels Sep 30, 2024
@fitzergerald
Copy link

Are these being worked on?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working kind/chore Necessary task language/go Golang related
Projects
None yet
Development

No branches or pull requests

3 participants