Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow switching Docker image in reusable test workflow #66

Closed
jwallwork23 opened this issue Nov 23, 2024 · 0 comments · Fixed by #67
Closed

Allow switching Docker image in reusable test workflow #66

jwallwork23 opened this issue Nov 23, 2024 · 0 comments · Fixed by #67
Assignees
@jwallwork23
Labels
install Installation instructions/process needs updating testing Extensions and improvements to the testing infrastructure

Comments

@jwallwork23
Copy link
Member

Currently the reusable test workflow assumes that the firedrake-parmmg Docker image is to be used. In #59 we introduce a separate image for UM2N.

An option to switch between Docker images will be required to complete mesh-adaptation/UM2N#59.
@jwallwork23 jwallwork23 added testing Extensions and improvements to the testing infrastructure install Installation instructions/process needs updating labels Nov 23, 2024
@jwallwork23 jwallwork23 self-assigned this Nov 23, 2024
@jwallwork23 jwallwork23 mentioned this issue Nov 23, 2024
Merged
@jwallwork23 jwallwork23 moved this from In Progress to In review in Mesh Adaptation development board Nov 23, 2024
jwallwork23 added a commit that referenced this issue Nov 23, 2024
@jwallwork23
Allow switching Docker image in reusable test workflow (#67)
7ba021e 
Closes #66.

Required for the completion of
mesh-adaptation/UM2N#59.

Note that the option defaults to `firedrake-parmmg` so that we only need
to provide this for the UM2N test suite.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jwallwork23 jwallwork23

Labels
install Installation instructions/process needs updating testing Extensions and improvements to the testing infrastructure
Projects
Mesh Adaptation development board
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Allow switching Docker image in reusable test workflow mesh-adaptation/docs
1 participant
@jwallwork23