Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can we drop pytorch3d dependency? #41

Open
jwallwork23 opened this issue Nov 2, 2024 · 3 comments
Open

Can we drop pytorch3d dependency? #41

jwallwork23 opened this issue Nov 2, 2024 · 3 comments
Assignees
@erizmr
Labels
bug Something isn't working question Further information is requested

Comments

@jwallwork23
Copy link
Member 

          Whenever I try to build pytorch3d on my laptop it crashes it. This hack is a temporary workaround.

Originally posted by @jwallwork23 in #40 (comment)

I find pytorch3d a problematic dependency and we only use one of its members: chamfer_distance. Is there an alternative package we could get this from?
@jwallwork23 jwallwork23 added bug Something isn't working question Further information is requested labels Nov 2, 2024
jwallwork23 added a commit that referenced this issue Nov 3, 2024
@jwallwork23
#41: FIXME for pytorch3d import
8f34b64
@erizmr
Copy link
Collaborator

erizmr commented Nov 5, 2024

I had a own implementation of this chamfer_distance , would have a test to see if it is consistent to the pytorch3d version.

@jwallwork23
Copy link
Member Author

Oh, nice! Would you be happy to take on this issue?

@erizmr erizmr self-assigned this Nov 7, 2024
@erizmr
Copy link
Collaborator

erizmr commented Nov 7, 2024

Oh, nice! Would you be happy to take on this issue?

Sure. Let me take on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@erizmr erizmr

Labels
bug Something isn't working question Further information is requested
Projects
Mesh Adaptation development board
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jwallwork23 @erizmr