Fix id allow list mistake in MQTT+HASS example #2602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You are right, good catch. Thanks! |
penfold42
pushed a commit
to penfold42/rtl_433
that referenced
this pull request
Aug 21, 2023
andrewjw
pushed a commit
to andrewjw/rtl_433
that referenced
this pull request
Sep 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It looks like the
--idsargument is broken right now and all devices are being exposed to HomeAssistant. The previous commit 315b98b tried to fix a bug.id in datadoesn't check if thedataobject has a key calledid, it's checking to see if thedatadict has the built-in function id.