From ee4e3291123597e52d37e017600bfb997c00c47f Mon Sep 17 00:00:00 2001 From: Matthew Epland Date: Wed, 3 Jan 2024 00:30:55 -0500 Subject: [PATCH] Update `.gitattributes` and `pull_request_template.md` (#37) * Use ** for recursive paths * ignore only html in media * Clean up PR template for easier use on github --- .gitattributes | 4 ++-- .github/pull_request_template.md | 23 ++++++++++------------- 2 files changed, 12 insertions(+), 15 deletions(-) diff --git a/.gitattributes b/.gitattributes index 250feaba..8697115d 100644 --- a/.gitattributes +++ b/.gitattributes @@ -1,5 +1,5 @@ # ignore all ana ipynb and html files in diffs and github languages stats ana/*.ipynb linguist-generated=true ana/*.html linguist-generated=true -# ignore media files in github languages stats -media/* linguist-documentation=true +# ignore html media files in github languages stats +media/**/*.html linguist-documentation=true diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 3b012bef..f80413bd 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,24 +1,21 @@ - # Description - + -# Type of change - -* [ ] Bug fix: Non-breaking change which fixes an issue -* [ ] New feature: Non-breaking change which adds functionality -* [ ] Breaking change: Fix or feature that would cause existing functionality to not work as expected -* [ ] This change requires a documentation update +# Type of Change + +* Bug fix: Non-breaking change which fixes an issue +* New feature: Non-breaking change which adds functionality +* Breaking change: Fix or feature that would cause existing functionality to not work as expected +* Docs: This change requires a documentation update # How Has This Been Tested? # Checklist - * [ ] I have performed a self-review of my own code * [ ] I have run the `pre-commit` checks -* [ ] The [github `tests` action](https://github.com/mepland/chance_of_showers/actions/workflows/tests.yml) is passing +* [ ] The [github `tests` action](https://github.com/mepland/chance_of_showers/actions/workflows/tests.yml) is passing * [ ] I have commented my code, particularly in hard-to-understand areas * [ ] I have updated the documentation as required + +