Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for setting country by regex #3

Open
HellPat opened this issue Jul 4, 2013 · 5 comments
Open

Allow for setting country by regex #3

HellPat opened this issue Jul 4, 2013 · 5 comments
Assignees

Comments

@HellPat
Copy link

HellPat commented Jul 4, 2013

In the current version i have to add a rule for each country i want to set.

be-nl/start.html
de-de/start.html
at-de/start.html

It would be very handy if i could use the defined regex to set the country.

url: (be)-(.*)
Redirect url: $2
Use regex to set country: true
Country: $1

@stefanheimes
Copy link
Member

Hi, i will merger #2 so the problem should be solved, isn't it ?

@HellPat
Copy link
Author

HellPat commented Jul 4, 2013

This is a different idea. With the current solution i have to set one redirect per country.
With this one all countrys could be handled by one rule.

a bit more flexible i think.

@stefanheimes
Copy link
Member

Ah sorry, now i understand what you mean.
Yeah, it's possible to add this function.

@HellPat
Copy link
Author

HellPat commented Jul 4, 2013

Would be less effort and more flexibility 👍

@HellPat
Copy link
Author

HellPat commented Jul 4, 2013

But this is not really important for me so i'm OK with the current solution. Would be interesting though what usecase we have for multiple selection of countries. Maybe this usecase collides with this feature.

@ghost ghost assigned stefanheimes Jul 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants