Enum c support #72
Merged
Enum c support #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-hek
requested changes
Apr 22, 2021
| @@ -181,10 +181,14 @@ defmodule Unifex.Specs.DSL do | |||
|
|
|||
| Elixir definition of %My.Struct{} should contain every field listed in specification and is not generated by Unifex | |||
| """ | |||
| defmacro type(struct) do | |||
| defmacro type({:"::", _, [_, {:%, _, _}]} = struct) do | |||
There was a problem hiding this comment.
Please update the doc, and also extend the example in the moduledoc so that it contained a struct and an enum
mickel8
requested changes
Apr 22, 2021
mickel8
requested changes
May 6, 2021
mat-hek
requested changes
May 7, 2021
| #{if_condition} { | ||
| char* enum_as_string = "#{type}"; | ||
| res = #{ | ||
| BaseType.generate_arg_serialize( |
There was a problem hiding this comment.
let's call the implementation directly here too
| ~g""" | ||
| char* enum_as_string = "#{type}"; | ||
| #{ | ||
| BaseType.generate_arg_serialize( |
There was a problem hiding this comment.
let's call the implementation directly here too
| @@ -0,0 +1,169 @@ | |||
| defmodule Unifex.CodeGenerator.BaseTypes.Enum do | |||
There was a problem hiding this comment.
lot's of duplicated code in this module, let's reuse some parts
FelonEkonom
force-pushed
the
enum-C-support
branch
from
1628497 to
936fa61
Compare
mickel8
reviewed
May 10, 2021
mat-hek
approved these changes
May 12, 2021
mickel8
approved these changes
May 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for mapping C/C++ enums into Elixir atoms and vice versa
closes #61