Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messages.Delete stream is not parsed #91

Closed
dmorn opened this issue Apr 12, 2024 · 1 comment
Closed

Messages.Delete stream is not parsed #91

dmorn opened this issue Apr 12, 2024 · 1 comment

Comments

@dmorn
Copy link
Contributor

dmorn commented Apr 12, 2024

This line here

defp do_handle_client_message(%Messages.DeleteStream{}, _header, state) do

Is never going to be called as the mapping of the message.ex module

  @amf_command_to_module %{
    "connect" => Messages.Connect,
    "releaseStream" => Messages.ReleaseStream,
    "FCPublish" => Messages.FCPublish,
    "createStream" => Messages.CreateStream,
    "publish" => Messages.Publish,
    "@setDataFrame" => Messages.SetDataFrame,
    "onMetaData" => Messages.OnMetaData
  }

is missing [FCUnpublish deleteStream]. PR coming to conform with this issue

@membraneframeworkadmin
Copy link

Issues related to membraneframework/membrane_rtmp_plugin are stored in membrane_core, so we close this issue here and we encourage you to open it there.

@membraneframeworkadmin membraneframeworkadmin closed this as not planned Won't fix, can't repro, duplicate, stale Apr 12, 2024
@github-project-automation github-project-automation bot moved this to Done in Smackore Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants