Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WHIP support #49

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add WHIP support #49

wants to merge 2 commits into from

Conversation

mat-hek
Copy link
Member

@mat-hek mat-hek commented Nov 28, 2024 •
edited
Loading

closes #26

@mat-hek mat-hek requested a review from FelonEkonom November 28, 2024 14:15
FelonEkonom
FelonEkonom reviewed Dec 2, 2024
View reviewed changes
Copy link
Member

@FelonEkonom FelonEkonom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will it work with CLI?

lib/boombox.ex Outdated
Comment on lines 152 to 155
if Keyword.keyword?(opts) do
opts = parse_whip_opts(opts)
{:webrtc, {:whip, opts}}
end
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we should raise if Keyword.keyword?/1 returns false

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we do here https://github.com/membraneframework/boombox/pull/49/files#diff-dc09e5f55160df34c7f0294fda9202894bd0e4d294dfcc14d5a1cece6a09f9a8R173

@mat-hek mat-hek requested a review from FelonEkonom December 10, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelonEkonom FelonEkonom Awaiting requested review from FelonEkonom

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for WHIP
2 participants
@mat-hek @FelonEkonom