Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a new built-in test for taps and targets to verify they can get their own package version correctly #2632

Open
edgarrmondragon opened this issue Aug 29, 2024 · 0 comments
Labels

Comments

@edgarrmondragon
Copy link
Collaborator

Feature scope

Taps (catalog, state, stream maps, tests, etc.)

Description

Sometimes the package name doesn't match the plugin/command name. For example, requiring changes like MeltanoLabs/target-snowflake@755795f to ensure the package version can be retrieved and printed.

It'd be nice if developers could get alerted to this during testing by having a test fail if the version can't be retrieved from package metadata.

--

If this is done, users would appreciate if we

  • Make it easy to turn the test off in case they don't care about name normalization
  • Instruct them on how to make the test pass by maybe updating package_name
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant