Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Parse dates with a more performant library than python-dateutil #2046

Closed
3 tasks done
edgarrmondragon opened this issue Nov 14, 2023 · 2 comments · Fixed by #2070
Closed
3 tasks done

refactor: Parse dates with a more performant library than python-dateutil #2046

edgarrmondragon opened this issue Nov 14, 2023 · 2 comments · Fixed by #2070

Comments

@edgarrmondragon
Copy link
Collaborator

edgarrmondragon commented Nov 14, 2023

Feature scope

CLI (options, error messages, logging, etc.)

Description

Pendulum seems to perform significantly better at parsing datetimes. Doing this would improve target performance by making record parsing faster.

Tasks

Preview Give feedback
  1. Accepting Pull Requests performance testing valuestream/SDK
@edgarrmondragon
Copy link
Collaborator Author

cc @BuzzCutNorman

@edgarrmondragon edgarrmondragon transferred this issue from meltano/meltano Nov 14, 2023
@BuzzCutNorman
Copy link
Contributor

@edgarrmondragon I was looking at pendulum alternatives. What about backports.datetime_fromisoformat. I came across it via this ciso8601 flow chart Should I use ciso8601?.

https://github.com/movermeyer/backports.datetime_fromisoformat

@edgarrmondragon edgarrmondragon changed the title refactor: Parse dates with Pendulum instead of python-dateutil refactor: Parse dates with a more performant library than python-dateutil Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants