Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Batch config schema is not appended to target's own config schema if the target supports the "batch" capability #1879

Closed
1 task
edgarrmondragon opened this issue Jul 27, 2023 · 0 comments · Fixed by #1880

Comments

@edgarrmondragon
Copy link
Collaborator

Singer SDK Version

0.30.0

Is this a regression?

  • Yes

Python Version

NA

Bug scope

Configuration (settings parsing, validation, etc.)

Operating System

NA

Description

Similar to what is done for taps:

sdk/singer_sdk/tap_base.py

Lines 210 to 211 in 781bb04

if PluginCapabilities.BATCH in capabilities:
merge_missing_config_jsonschema(BATCH_CONFIG, config_jsonschema)

but I don't think we should add to the default target capabilities and let each target handle that on their own (see MeltanoLabs/target-snowflake#99):

@classproperty
def capabilities(self) -> list[CapabilitiesEnum]:
"""Get target capabilities.
Returns:
A list of capabilities supported by this target.
"""
return [
PluginCapabilities.ABOUT,
PluginCapabilities.STREAM_MAPS,
PluginCapabilities.FLATTENING,
]

Code

No response

@edgarrmondragon edgarrmondragon changed the title bug: Batch config schema is not appended to target's own config schema if the target supports the _batch_ capability bug: Batch config schema is not appended to target's own config schema if the target supports the "batch" capability Jul 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant