-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highlight not updated when the property is changed #43
Comments
I think your issue is similar to this one: #37 It seems wiht React Virtual Window is scrolling to the end of the first virtual frame or something. |
I just released 5.2.1 can you try it and report back i think its fixed. |
Hi melloware! Thanks for your attention.
|
yep i see that too with a stackblitz: https://stackblitz.com/edit/vitejs-vite-lesej7?file=package.json,src%2FApp.tsx&terminal=dev |
I see why. highlight:
previousHighlight === Range(0, 0)
? getHighlightRange(highlight)
: previousHighlight || getHighlightRange(previousHighlight), The old code intentionally only set the Highlight on initialization but after that it was controlled by your mouse clicks. I wonder if this is so highlighting would not be lost between re-renders? |
Hi,
It seems that changing highlight property doesn't update the component.
I have a react code like below to scroll AND highlight to the specific line.
When the lineNumber is updated, LazyLog is scrolled to the line number as expected. But the highlight is not updated.
Do you have any idea?
The text was updated successfully, but these errors were encountered: