-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Regex Search Support #39
Comments
PR would be great! |
OK @ido123net i can see why the original developer only did "Knuth–Morris–Pratt" string matching for search. Say you have a very large log file this string searching is way faster and more efficient than an expensive RegExp search. |
Yes, I also found it, I will try to leave the KMP part as is. My idea is to implement a new function to search with regex, this will of-course be less efficient, therefore it will not be the default. |
I just committed some JS doc changes to document that class just so I know why it was doing it! |
@melloware look at #40 it works, but it breaks the highlights and filtering lines. |
I saw, I pulled the latest 😉 |
Yep I can point you to wheee the highlighting is happening and why it's not working. Let me review |
OK the bug is in here: react-logviewer/src/components/Utils/utils.ts Lines 135 to 231 in 3646bca
It does some magic tro remove regex strings and do a plain text match on highlighted words. |
Feature Request:
Please add regex search functionality to
react-logviewer
.This would enable more flexible and powerful search options, allowing users to match complex patterns in logs.
I'd be glad to help with a PR if needed! 😊
Keep in mind I'm new to the React world.
Thank you!
The text was updated successfully, but these errors were encountered: