-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Watch out for regressions in the Table Detector #11
Comments
Yes, I'm working on those tests right now. 4/8 that are currently failing come from the TestTableDetection: 10, 26, 35 and 46. It seems that the horizontalRulings and verticarlRulings have differences and I guess is the way that we generate the images with pdfbox2.0
But I'm not sure yet. I'll keep you posted. |
Thanks! You're aware of the Debug tool, right? It might be useful for, well, debugging.
There's a bunch of options that you can use in the debugger:
|
This is great! I didn't know about this tool |
Hey @melisabok,
I just ran the tests in your branch. There's a special test suite for running the table detection algorithms.
Cumulative results for your branch are:
…
master
, on the other hand, gives these results:This difference might go away when you make the other tests pass, but it's something to keep an eye out for anyway.
Thanks!
The text was updated successfully, but these errors were encountered: