Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

exploration: Store external information in internal attributes #749

Open
anmonteiro opened this issue Oct 2, 2023 · 4 comments
Open

exploration: Store external information in internal attributes #749

anmonteiro opened this issue Oct 2, 2023 · 4 comments
Milestone

Comments

@anmonteiro
Copy link
Member

Currently Melange external attributes store some internal marshaled data in the primitive payload, e.g.:

external document: t = "SOME_MARSHALED_DATA_GETS_INSERTED_HERE"

we want to explore storing that data in e.g. [@internal.melange-external "PAYLOAD_HERE"]

@jchavarri
Copy link
Member

Related to #346.

@jchavarri
Copy link
Member

Also related to #739.

@benbellick
Copy link

Hi! I opened up the above issue reasonml/reason-react#853, which I believe would be solved by this ticket. To repeat briefly, my editor is unable to handle the unexpected characters produced by the lsp when my cursor is over module definitions. I am using Emacs w/ Eglot.

Alternatively, is there a different recommended developer experience for Emacs users?

@anmonteiro
Copy link
Member Author

no workaround at the moment, unfortunately.

An alternative to this issue, that might be easier to prototype, is to patch the Reason outcome printer to detect that the external has marshaled information, and not print that. But it'd only work for Reason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants