HSC-287: Configured clinical forms.

[usamaidrsk]

https://mekomsolutions.atlassian.net/browse/HSC-287

[usamaidrsk]

Some forms have an unsupported behavior on the RFE(nested grouping) i.e Historique de santé and Signes vitaux , which I am working on from this PR > openmrs/openmrs-esm-form-engine-lib#421

[Ruhanga]

Thanks for the PR @usamaidrsk. Generally looking good. Three things,

1.) Could you update the forms with their encounter types recently added through @kazlaw's recently merged PR
2.) Let's try to maintain the snake-case file names of each form as much as possible
3.) Let's also remove any accents from the names, i.e.

Examen gynécologique.json ➔ examen_gynecologique.json

[usamaidrsk]

I have added respective encounterTypes, and these encounterTypes look to be missing Triage, Signes vitaux,, Moyen de transport, Anthropométrie

cc @Ruhanga @kazlaw

[Ruhanga]

The only change that should be part of this PR on the Vitals and Biometrics form is, 1.) change of file name into snake_case, 2.) attaching of the correct encounter type UUID. And nothing else I believe otherwise the current changes on the form seem to misconfigure it.

[usamaidrsk]

I have reverted the changes!
Thanks @Ruhanga

[Ruhanga]

Thanks, @usamaidrsk. Overall, LGTM. Could you please test these forms on an instance, perhaps via Gitpod? You can use this link to spin up an instance based on the branch from this PR. This is to verify that things like the forms' UUIDs remain consistent and the forms load without issues.

[Ruhanga]

Overral looking good. Thanks @usamaidrsk. One last thing to verify, could you make sure that the concepts' UUIDs (for grouping concept sets, question concepts and answer concepts ) used on the React forms are the very ones that where previously used with the Bahmni forms?

[usamaidrsk]

Overral looking good. Thanks @usamaidrsk. One last thing to verify, could you make sure that the concepts' UUIDs (for grouping concept sets, question concepts and answer concepts ) used on the React forms are the very ones that where previously used with the Bahmni forms?

Yeah, for that I was confirming on creation.

[Ruhanga]

Yeah, for that I was confirming on creation.

Could you have a second look and verify this, for example, looking at the form historique_de_sante.json the concept for Smoking Duration is not the original one used in the previous corresponding Bahmni form. It should have been dbab4772-1814-466f-a4ff-22aceca57200.

[usamaidrsk]

Could you have a second look and verify this, for example, looking at the form historique_de_sante.json the concept for Smoking Duration is not the original one used in the previous corresponding Bahmni form. It should have been dbab4772-1814-466f-a4ff-22aceca57200.

Where do I test this from, looks like this http://hsc-cd04.mekomsolutions.net environment is broken

[kazlaw]

Could you have a second look and verify this, for example, looking at the form historique_de_sante.json the concept for Smoking Duration is not the original one used in the previous corresponding Bahmni form. It should have been dbab4772-1814-466f-a4ff-22aceca57200.

Where do I test this from, looks like this http://hsc-cd04.mekomsolutions.net environment is broke

It should be up now @usamaidrsk

Cc: @Ruhanga

[Ruhanga]

Looks generally good. One missed update on the concepts generally with an example below.

[Ruhanga]

You've changed the concept's UUID but missed updating the label, i.e. instead of being Smoking Duration (Year(s)) it should be Smoking Duration?

[usamaidrsk]

I have updated all manually appended label units.
This should be done by the RFE, and I created a ticket for this.

[Ruhanga]

I believe we're nearly there. @usamaidrsk, could you verify on a new running instance based on this PR whether the form schema from its file is preserved at runtime when checked through the form builder? If not, you'll have to update the fform's uuid in it's config file.

[usamaidrsk]

I believe we're nearly there. @usamaidrsk, could you verify on a new running instance based on this PR whether the form schema from its file is preserved at runtime when checked through the form builder? If not, you'll have to update the fform's uuid in it's config file.

I've verified that @Ruhanga , and yes the form schemas are preserved.

[Ruhanga]

LGTM!