(feat) HSC-286: Add visit attributes 'Mode of arrival' and 'Level of emergency severity assessment' #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vasharma05
force-pushed
the
HSC-286/visit-attributes
branch
from
10c1a0f
to
a635400
Compare
vasharma05
force-pushed
the
HSC-286/visit-attributes
branch
from
a635400
to
620dd6c
Compare
vasharma05
commented
Sep 30, 2024
There was a problem hiding this comment.
@kazlaw, I have a few questions, please have a look. Alongside, the french translations are missing for all the concepts' texts.
Thanks!
| @@ -0,0 +1,3 @@ | |||
| Uuid,Void/Retire,Entity name,Name,Description,Min occurs,Max occurs,Datatype classname,Datatype config,Preferred handler classname,Handler config,_order:1000 | |||
| a56959b5-4fe2-4d69-a553-fdc77957c48b,,Visit,Mode of arrival,The mode of arrival that the patient took to the location,0,1,org.openmrs.customdatatype.datatype.ConceptDatatype,f61a8a18-cb64-4a63-bc28-56b4789941ff,,, | |||
| d63554a8-4979-4719-a918-1ccc3d924ed7,,Visit,Level of emergency severity assessment,Level of emergency severity assessment,0,1,org.openmrs.customdatatype.datatype.ConceptDatatype,bbb02557-0277-4979-a1fa-b0020f136066,,, | |||
There was a problem hiding this comment.
Hi @kazlaw!
The Level of emergency severity assessment concept is being used in the triage.json form, and I have used the same UUID for the above visit attribute type's Datatype config mapping. But I didn't find the concept defined anywhere, do we need to define the concept mentioned above?
Thanks!
Comment on lines
2
to
5
| 2fdfe136-263c-4d59-b96e-ae4a76d9445f,,,Minibus,Minibus,Minibus,Minibus,,,Misc,N/A,,,,,,,,,,, | ||
| 93298e19-1e9a-4306-beec-c134d0989a0a,,,Ambulated,Ambulated,Ambulated,Ambulated,,,Misc,N/A,,,,,,,,,,, | ||
| 693c7001-1433-4ebb-aee9-1ab0dd1787f6,,,Car,Car,Car,Car,,,Misc,N/A,,,,,,,,,,, | ||
| f61a8a18-cb64-4a63-bc28-56b4789941ff,,,Mode of arrival,Mode of arrival,Mode of arrival,Mode of arrival,,,Question,Coded,,Minibus;Ambulated;Car;Other,,,,,,,,, |
There was a problem hiding this comment.
@kazlaw, I have created new UUIDs for these concepts, should we use the same UUIDs which were being used in the older implementation?
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 new visit attributes