Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setting: "distinctAttribute" type inconsistency #273

Closed
Joepin8 opened this issue Jul 21, 2023 · 5 comments · Fixed by #295
Closed

setting: "distinctAttribute" type inconsistency #273

Joepin8 opened this issue Jul 21, 2023 · 5 comments · Fixed by #295
Labels
enhancement New feature or request

Comments

@Joepin8
Copy link

Joepin8 commented Jul 21, 2023

Description
When trying to set the "distinctAttribute" setting, the bundle expects an array, while the meili search setting object expects a string value.

Expected behavior
When setting a string in the bundle's config, the value's type should not result in a type error.

Current behavior
Either a type error is thrown by the bundle or through meili search.

Environment:

  • OS: Ubuntu 22.04
  • Meilisearch version: v1.2.0
  • meilisearch-symfony version: v0.13.0
@norkunas
Copy link
Collaborator

I'm working on a PR to properly define all settings config schema, but not sure when will finish it.
WIP here

@Joepin8
Copy link
Author

Joepin8 commented Jul 21, 2023

Okay, thanks for letting me know. Shall I close this issue then?

@norkunas
Copy link
Collaborator

You can leave it open :) Also #256 is related

@brunoocasali brunoocasali added the enhancement New feature or request label Aug 3, 2023
@Joepin8
Copy link
Author

Joepin8 commented Sep 28, 2023

Can I help to have this in the next release?

@curquiza
Copy link
Member

Hello @Joepin8
The help of the community is more than welcome here, feel free to open PRs 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants