Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused parameters #3

Open
jerobarraco opened this issue Sep 22, 2020 · 0 comments
Open

Unused parameters #3

jerobarraco opened this issue Sep 22, 2020 · 0 comments

Comments

@jerobarraco
Copy link

https://github.com/meiXXI/PointCloudCrust/blob/cd654b594bf46c437707da7e93161b24c5a8fbc2/src/main/java/net/ricebean/tools/pointcloud/PointCloudCrustImpl.java#L171

Suggestion:
you're not using the triangle parameter. And i think you can access the pointCloud directly, since it's stored in the class, so you don't need it either.

Sidenote:
i thought on combining both loops and check both balls at the same time, but i realized that having the loop separate avoids doing the heavy calculation for one of the balls that sometimes might be unnecessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant