You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Suggestion:
you're not using the triangle parameter. And i think you can access the pointCloud directly, since it's stored in the class, so you don't need it either.
Sidenote:
i thought on combining both loops and check both balls at the same time, but i realized that having the loop separate avoids doing the heavy calculation for one of the balls that sometimes might be unnecessary.
The text was updated successfully, but these errors were encountered:
https://github.com/meiXXI/PointCloudCrust/blob/cd654b594bf46c437707da7e93161b24c5a8fbc2/src/main/java/net/ricebean/tools/pointcloud/PointCloudCrustImpl.java#L171
Suggestion:
you're not using the triangle parameter. And i think you can access the pointCloud directly, since it's stored in the class, so you don't need it either.
Sidenote:
i thought on combining both loops and check both balls at the same time, but i realized that having the loop separate avoids doing the heavy calculation for one of the balls that sometimes might be unnecessary.
The text was updated successfully, but these errors were encountered: