Skip to content
This repository has been archived by the owner on Aug 16, 2021. It is now read-only.

Using pre-built releases with :ZkInstall #22

Open
mickael-menu opened this issue Apr 29, 2021 · 1 comment
Open

Using pre-built releases with :ZkInstall #22

mickael-menu opened this issue Apr 29, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@mickael-menu
Copy link
Collaborator

:ZkInstall is currently building zk from scratch, which has a few advantages:

  • Able to install the latest HEAD version
  • Simpler to implement in zk.nvim
  • It can build the right architecture needed by the user

But it also poses a few problems:

  • The user must have the Go toolkit installed
  • zk requires specific Go tags to build, which might change from one version to the other (see this PR for an example)
  • The installed zk build will be "unversioned" and might not be 100% stable

An alternative could be to use the GitHub JSON API to fetch the latest pre-built releases from https://api.github.com/repos/mickael-menu/zk/releases/latest

This requires to know the architecture of the computer. If the architecture is not covered, we could always fall back on the go get solution.

@mickael-menu mickael-menu added the enhancement New feature or request label Apr 29, 2021
@megalithic
Copy link
Owner

Great suggestion! Would offer more flexibility overall too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants