Add api_port option #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add api_port to the driver options to support custom proxmox ports.
IamLunchbox
reviewed
Sep 22, 2024
| @@ -190,6 +190,7 @@ def run_module(): | |||
| module = AnsibleModule( | |||
| argument_spec=dict( | |||
| api_host=dict(type='str', required=True), | |||
| api_port=dict(type='int', default=None), | |||
There was a problem hiding this comment.
Maybe set 8006 here as defeault?
IamLunchbox
reviewed
Sep 22, 2024
| @@ -6,6 +6,7 @@ driver: | |||
| name: molecule-proxmox | |||
| options: | |||
| api_host: "${PROXMOX_HOST}" | |||
| api_port: ${PROXMOX_PORT} | |||
There was a problem hiding this comment.
Maybe set 8006 here as defeault?
|
Sorry, I was not done with the review yet, I am still setting up the test env for molecule-proxmox, thats why my last two comments are belated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add api_port to the driver options to support custom proxmox ports.