From 7156a1045dc5061e41257ce999947716739248a8 Mon Sep 17 00:00:00 2001 From: Alex Dolski Date: Fri, 1 Mar 2024 13:31:24 -0600 Subject: [PATCH 1/2] Fix the "All Items" tab trying to load a nonexistent URL path --- app/assets/javascripts/items.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/assets/javascripts/items.js b/app/assets/javascripts/items.js index deaba2e5..f2ece106 100644 --- a/app/assets/javascripts/items.js +++ b/app/assets/javascripts/items.js @@ -59,7 +59,7 @@ const ItemsView = { // When the All Items tab is selected, remove all other search input. allItemsTab.on("show.bs.tab", function () { - window.location = "/items"; + window.location = "/search"; }); // When the Simple Search or Advanced Search submit button is clicked, From 467e48e8e4c3b25b7d21d9a4e2db96dbd4032754 Mon Sep 17 00:00:00 2001 From: Alex Dolski Date: Fri, 1 Mar 2024 13:31:45 -0600 Subject: [PATCH 2/2] Fix tab aria-selected values --- app/views/search/index.html.haml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/app/views/search/index.html.haml b/app/views/search/index.html.haml index 9c51a8e8..ca47ed4d 100644 --- a/app/views/search/index.html.haml +++ b/app/views/search/index.html.haml @@ -20,14 +20,14 @@ role: "tab", type: "button", "aria-controls": "simple-search", - "aria-selected": "true"} Simple Search + "aria-selected": "false"} Simple Search %li.nav-item{role: "presentation"} %button#advanced-search-tab.nav-link{"data-bs-toggle": "pill", "data-bs-target": "#advanced-search", role: "tab", type: "button", "aria-controls": "advanced-search", - "aria-selected": "true"} Advanced Search + "aria-selected": "false"} Advanced Search .tab-content #all-items.tab-pane.fade.show.active{role: "tabpanel", "aria-labelledby": "all-items-tab"}