Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker-compose.yml should be for flare instead of blaze #184

Open
haemka opened this issue Jul 19, 2024 · 3 comments
Open

docker-compose.yml should be for flare instead of blaze #184

haemka opened this issue Jul 19, 2024 · 3 comments
Assignees
Milestone

Comments

@haemka
Copy link

haemka commented Jul 19, 2024

The docker-compose.yml in this project should rather contain a configuration for running flare instead of a blaze test server. The documentation should refer to official blaze documentation on how to set up blaze.

Containing a docker-compose.yml and a Dockerfile for generally different purposes is just confusing.

@alexanderkiel
Copy link
Member

The docker-compose.yml is used for development of FLARE, were one needs a Blaze server to be able to start FLARE. In which use case do you check out the FLARE repo? Development in FLARE or deployment of a system using FLARE?

@haemka
Copy link
Author

haemka commented Jul 19, 2024

I don't need a Blaze for running FLARE. Regardless of development or deployment. I can use whatever FHIR server I want to use. Of course setting up Blaze for development purposes might be a good choice, but as I mentioned putting a Dockerfile and a docker-compose.yml with generally different purposes in a repository is at least confusing.

@alexanderkiel alexanderkiel self-assigned this Jul 22, 2024
@alexanderkiel alexanderkiel added this to the v2.4.0 milestone Jul 22, 2024
@alexanderkiel
Copy link
Member

Ok you are right, I'll fix that.

bastianschaffer added a commit that referenced this issue Sep 3, 2024
Fixes: #184

Also updated README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants