Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service links are broken when manually editing content (i.e in Element) #97

Open
aofn opened this issue Nov 17, 2023 · 0 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@aofn
Copy link
Member

aofn commented Nov 17, 2023

Describe the bug
Pad links or sketch links are broken when the link inside the room was edited.

To Reproduce

  • Create an /etherpad pad
  • find the corresponding room in Element and edit the message. (make sure link is still valid)
  • open the pad in /spaces

Expected behavior
Link should not be broken after editing (as long as link is till valid)

Screenshots
image

Possible fix

check if the object has a m.new_content key and if so return it otherwise return body

{
   "msgtype":"m.text",
   "body":" * http://spacedeck.localhost/spaces/8f51b463-a9a2-46f8-8646-d037f8438984",
   "m.new_content":{
      "msgtype":"m.text",
      "body":"http://spacedeck.localhost/spaces/8f51b463-a9a2-46f8-8646-d037f8438984"
   },
   "m.relates_to":{
      "rel_type":"m.replace",
      "event_id":"$VNqjjshe1Be75fLYAvqDdd0MRyhvBJXpFZaE3o9MFWs"
   }
}
@aofn aofn added the bug Something isn't working label Nov 17, 2023
@robertschnuell robertschnuell self-assigned this Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants