Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/write: simplify and streamline new item workflow #130

Open
andirueckel opened this issue Jan 22, 2024 · 6 comments · May be fixed by #133
Open

/write: simplify and streamline new item workflow #130

andirueckel opened this issue Jan 22, 2024 · 6 comments · May be fixed by #133

Comments

@andirueckel
Copy link
Member

andirueckel commented Jan 22, 2024

For our first release candidate, we wanted to simplify and streamline the new item workflow for /write. Currently there’s too many options, as #129 describes, hence the following suggestion with conditional <input type="password"> field.

/write             [+]  |  h2 + sub-menu button
                        |  br
Name your item:         |  h3
__________________      |  input type="text"
                        |  br
[✓] Password?           |  input type="checkbox" + h3
__________________      |  input type="password"

Additionally, MyPads allows to change the visibility from public (world-readable if URL is known) to private (password-protected), and vice-versa; as well as changing the password itself. In my opinion, adding this functionality would be more important than adding external public pads via URL—which should be handled similar to other hyperlinks, not /write-specific.

What do you think, @aofn @fnwbr?

@aofn
Copy link
Member

aofn commented Jan 23, 2024

I like the idea of this. I would suggest just displaying an optional password input instead of a checkbox. But I'm fine with both!

@andirueckel
Copy link
Member Author

andirueckel commented Jan 23, 2024

Thought about this, too. We would need to indicate, that it’s an optional input/parameter, and explain what the password is meant for, e.g. “access password” or “password protection”; we probably can’t and shouldn’t do this via the placeholder text, as the <input type="password" /> placeholder text is and should(?) be concealed, i.e. each character be displayed as bullet point?

We could implement/test it as follows:

/write                      [+]  |  h2 + sub-menu button
                                 |  br
Name your item:                  |  h3
__________________               |  input type="text"
                                 |  br
Access password: (optional)      |  input type="checkbox" + h3 + italic “(optional)“
__________________               |  input type="password"
                                 |  br
<CANCEL>       <CREATE>          |  cancel/confirm button component
/write                      [+]  |  h2 + sub-menu button
                                 |  br
Name your item:                  |  h3
__________________               |  input type="text"
                                 |  br
Password protection: (optional)  |  input type="checkbox" + h3 + italic “(optional)“
__________________               |  input type="password"
                                 |  br
<CANCEL>       <CREATE>          |  cancel/confirm button component

Not happy with the (optional) placement; but I’m sure we’ll find some good place.

@fnwbr
Copy link
Member

fnwbr commented Jan 23, 2024

👍 No strong preference, but I'd choose option (1) with the checkbox.

EDIT: @andirueckel mentioned he'd like the checkbox to be a toggle. @aofn Maybe this is the chance to start embedding shadcn/ui components?

@aofn
Copy link
Member

aofn commented Jan 24, 2024

sounds good, also happy with a toggle

@aofn
Copy link
Member

aofn commented Jan 24, 2024

I'll create a draft PR for this

@andirueckel
Copy link
Member Author

andirueckel commented Jan 24, 2024

@aofn Well, I visually kinda like it, but also it feels wrong to use a toggle, i.e. “switch” to show/hide other UI elements.

There’s also the “accordion” and “collapsible” components which maybe are more suited for this purpose?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants