Makes configuration uploadable thru UI #240
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathanbataire
commented
Jan 16, 2025
| @@ -90,7 +93,7 @@ export class Config { | |||
| public static getParentProperty(contactType: ContactType): HierarchyConstraint { | |||
| const parentMatch = contactType.hierarchy.find(c => c.level === 1); | |||
| if (!parentMatch) { | |||
| throw new Error(`hierarchy at level 1 is required: "${contactType.name}"`); | |||
| throw new Error(`hierarchy at level 1 is required: "${contactType?.name}"`); | |||
| const contactMatch = config.contact_types.find(c => c.name === name); | ||
| public static async getContactType(name: string) : Promise<ContactType> { | ||
| const {config} = await init(); | ||
| const contactMatch = config.contact_types.find(c => c?.name === name); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Current app requires rebuilding and re-deploying a app in order to change config
This approach introduces uploadable config making it easier to change configuration
The app defaults to the prebuilt config, once a new file is uploaded it overrides any prebuilt config
Configuration can only be updated by CHT admins
Fixes #194
changes