No patch file for MediaWiki 1.28

[umbrualbert]

Hi

I have noticed that MediaWiki 1.28 have been released but there is currently no patch available for it?

Thanks

Umbru

[hmphu]

@umbrualbert can you please take a look to my PR #79 it might help

[Mayzie]

Hi @hmphu

When trying yours on a 1.28.1 install, I get the following when trying to apply the patch:

$ patch -p1 < extensions/IntraACL/patches/IntraACL-MediaWiki-1.27.2.diff 
can't find file to patch at input line 5
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/templates/HACL_ACLEditor.tpl.php b/templates/HACL_ACLEditor.tpl.php
|index ca7d345..4d669a5 100644
|--- a/templates/HACL_ACLEditor.tpl.php
|+++ b/templates/HACL_ACLEditor.tpl.php
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
4 out of 4 hunks ignored
can't find file to patch at input line 93
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/templates/HACL_ACLList.tpl.php b/templates/HACL_ACLList.tpl.php
|index 8a543ab..5c4370b 100644
|--- a/templates/HACL_ACLList.tpl.php
|+++ b/templates/HACL_ACLList.tpl.php
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 133
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/templates/HACL_ACLListContents.tpl.php b/templates/HACL_ACLListContents.tpl.php
|index 175a915..d2a0296 100644
|--- a/templates/HACL_ACLListContents.tpl.php
|+++ b/templates/HACL_ACLListContents.tpl.php
--------------------------
File to patch: 
Skip this patch? [y] 
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 171
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/templates/HACL_GroupEditor.tpl.php b/templates/HACL_GroupEditor.tpl.php
|index b25cc5b..7d5687e 100644
|--- a/templates/HACL_GroupEditor.tpl.php
|+++ b/templates/HACL_GroupEditor.tpl.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored
can't find file to patch at input line 236
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/templates/HACL_GroupList.tpl.php b/templates/HACL_GroupList.tpl.php
|index f090fe1..1e57cea 100644
|--- a/templates/HACL_GroupList.tpl.php
|+++ b/templates/HACL_GroupList.tpl.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 249
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/templates/HACL_GroupListContents.tpl.php b/templates/HACL_GroupListContents.tpl.php
|index 0b3c253..f17c9a8 100644
|--- a/templates/HACL_GroupListContents.tpl.php
|+++ b/templates/HACL_GroupListContents.tpl.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
1 out of 1 hunk ignored
can't find file to patch at input line 269
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/templates/HACL_QuickACL.tpl.php b/templates/HACL_QuickACL.tpl.php
|index 47f5d9b..a6a0869 100644
|--- a/templates/HACL_QuickACL.tpl.php
|+++ b/templates/HACL_QuickACL.tpl.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
4 out of 4 hunks ignored
can't find file to patch at input line 337
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/templates/HACL_Toolbar.tpl.php b/templates/HACL_Toolbar.tpl.php
|index 7291fe1..d8a711b 100644
|--- a/templates/HACL_Toolbar.tpl.php
|+++ b/templates/HACL_Toolbar.tpl.php
--------------------------
File to patch:
Skip this patch? [y]
Skipping patch.
2 out of 2 hunks ignored

[hmphu]

hi @Mayzie

Thank you for your testing. I forgot to update the file path in the patch. I have just pushed a new commit, please try again.

[Mayzie]

@hmphu

Thank you! It has patched fine, and as far as I can tell from some preliminary testing, it works like a charm.

[hmphu]

That's so cool. I'm appreciated your helps, thank you very much for your testing

[vitalif]

Thanks for providing a rebased patch for 1.28!
Sorry, I don't have much time to release them as quickly as new MediaWiki versions come out.
I would like to merge your pull request, the single point to note is that 1.28 may have some new special pages and some new API endpoints that should also be protected - can you check them out? includes/api/* includes/specials/*

[centaure]

I tried your patch. Direct access to the page is getting protected but protected page title shows up in search results, DPL, Category, Recent Changes etc. I would not have been much worried about just title showing up. But search is actually going inside the content of protected page. You can search a line of text inside the protected page with no viewing rights.

Is this cache related problem or does this mean that many more files need to be patched?

[centaure]

@hmphu Just want to clarify that above problems do not exist in IntraACL 1.27 patch available @vitalif on this site. 1.28 Patch that I downloaded from your hmphu repository has these issues.
Did you started from the patch provided by @vitalif ? None of these issues exist there.
I switched off cache and the issues remain. So it does not seem like a cache issue.

[vitalif]

Where did you take the patch from? I couldn't find it in the pull request.

[centaure]

I got it from here: https://github.com/hmphu/IntraACL

[Mayzie]

Yeah.

MediaWiki also throws a 500 error when trying to access the root / main page when not logged in. The login page URL works, and can be accessed, after which no more errors are thrown.

[vitalif]

I see no patch for 1.28 there.

[Mayzie]

@vitalif He/She made a pull request for this project: 4c8069d

All I did to apply their patch was clone their repo (as I would yours), and then follow the patch application instructions (applying patch 1.27.2 to my 1.28 installation). It, however, is incomplete.

[vitalif]

That's something strange, not a rebase:-) to rebase you need to git clone official MW repo, git checkout REL1_27, apply the patch (manually via patch -p1 < patchfile + git commit or maybe via git am) and then git rebase origin/REL1_28 it

[vitalif]

Then you'll get a bunch of conflicts, fix them etc...