Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rm gui.py, mv launcher and uploader to subfolders #213

Open
wants to merge 19 commits into
base: python3
Choose a base branch
from
Open

Conversation

robkam
Copy link
Member

@robkam robkam commented Oct 25, 2023

I had to tweak init & main files to keep dumpgenerator, launcher and uploader still working the same as they were.

@robkam robkam added the enhancement New feature or request label Oct 25, 2023
@robkam
Copy link
Member Author

robkam commented Oct 26, 2023

I don't know which files get the shebang
#!/usr/bin/env python3

@robkam robkam mentioned this pull request Nov 5, 2023
@elsiehupp
Copy link
Member

FWIW the reason I've left gui.py is that it connects to the rest of the code in a way that the other upstream tools do not. So I'd rather try and fix it than just remove it (even if it's not perfect).

@robkam
Copy link
Member Author

robkam commented Mar 28, 2024

Okay. It looks unfinished. Perhaps it should be written from scratch.

@robkam
Copy link
Member Author

robkam commented Mar 28, 2024

Dumpgenerator.py itself could do the two checks mentioned here in USAGE.md.

@robkam
Copy link
Member Author

robkam commented Jun 13, 2024

FWIW the reason I've left gui.py is that it connects to the rest of the code in a way that the other upstream tools do not. So I'd rather try and fix it than just remove it (even if it's not perfect).

Launcher.py, uploader.py and gui.py should then be removed from https://github.com/mediawiki-client-tools/upstream-to-sort

Launcher I've sorted already, (at #221). Uploader and gui will get fixed as well eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants