Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Placate mypy (redux) (Sourcery refactored) #198

Closed
wants to merge 1 commit into from

Conversation

sourcery-ai[bot]
Copy link

@sourcery-ai sourcery-ai bot commented Sep 8, 2023

Pull Request #197 refactored by Sourcery.

If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.

NOTE: As code is pushed to the original Pull Request, Sourcery will
re-run and update (force-push) this Pull Request with new refactorings as
necessary. If Sourcery finds no refactorings at any point, this Pull Request
will be closed automatically.

See our documentation here.

Run Sourcery locally

Reduce the feedback loop during development by using the Sourcery editor plugin:

Review changes via command line

To manually merge these changes, make sure you're on the placate-mypy-redux branch, then run:

git fetch origin sourcery/placate-mypy-redux
git merge --ff-only FETCH_HEAD
git reset HEAD^

Help us improve this pull request!

@sourcery-ai sourcery-ai bot requested a review from elsiehupp September 8, 2023 16:27
@sourcery-ai sourcery-ai bot force-pushed the sourcery/placate-mypy-redux branch from 751aaa6 to 0005550 Compare September 8, 2023 16:32
@sourcery-ai sourcery-ai bot force-pushed the sourcery/placate-mypy-redux branch from 0005550 to ea1c09f Compare September 8, 2023 16:37
@elsiehupp elsiehupp force-pushed the placate-mypy-redux branch 2 times, most recently from 1cc3eb9 to 310ad8f Compare September 8, 2023 16:39
@sourcery-ai sourcery-ai bot force-pushed the sourcery/placate-mypy-redux branch from ea1c09f to d502048 Compare September 8, 2023 16:40
@sourcery-ai sourcery-ai bot force-pushed the sourcery/placate-mypy-redux branch from d502048 to b9d485c Compare September 8, 2023 16:41
xml = str(r.text)
xml = r.text
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Function getXMLHeader refactored with the following changes:

@randomnetcat
Copy link
Collaborator

Closing for now, unless and until the original PR is revisited.

@randomnetcat randomnetcat deleted the sourcery/placate-mypy-redux branch September 24, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant