Built in element selectors should respect component encapsulation

[skulptur]

A component should only be able to select elements that are in the scope of this data-component element. Elements within other data-component elements should be handled in their own component. If that access is needed it should be explicit.

[ThaNarie]

This pattern is already somewhat enforced through the existing getElement:
https://github.com/mediamonks/muban-core/blob/master/src/lib/CoreComponent.ts#L35

Passing a second container argument (that is different from the element) makes it already more explicit (although it's probably mostly used for more specific selectors, rather than from other components, but still).

What do you propose?

[skulptur]

I think what we have only takes care of selecting elements down the tree. But it should be down the tree except if it's in a child component's scope, if that makes sense.

[skulptur]

The parents are breaking encapsulation of their children right now.

[ThaNarie]

That I agree with!

Maybe we can do something that the queried elements first will be checked in which (nearest) parent they are situated, and throw an error before returning them - unless you explicitly pass a flag that overrides this behaviour.

this.getElement('.some-class-in-child-compment', { ignoreCheck: true });