Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating suggestions without translations should not trigger warnings in console #6

Open
petervdn opened this issue Nov 30, 2018 · 3 comments

Comments

@petervdn
Copy link

No description provided.

@petervdn
Copy link
Author

I think you should be able to just put text in there. (it works, but output in console makes it look like there is something wrong)

@n0cha
Copy link

n0cha commented Dec 17, 2018

Agreed. But should we not have warnings at all then for missing translations?
Or should we not automatically translate suggestions?
Or should only suggestions not trigger translation warnings?

@petervdn
Copy link
Author

If supplying a regular text is one of the intended ways to use that method (which it is, and should be), then i don't think there should be warnings at all.

In my opinion the main issue is that the parameter can be multiple things (a text or a key to a translatable text), and i don't agree on that approach (same for the say method). It's shorter, but i think it gives more problems than it solves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants