Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guidelines for submitting and reviewing pull requests #22

Open
skulptur opened this issue Aug 10, 2020 · 0 comments
Open

Guidelines for submitting and reviewing pull requests #22

skulptur opened this issue Aug 10, 2020 · 0 comments
Assignees

Comments

@skulptur
Copy link
Contributor

  • Title and description: what should they contain?
  • Encourage self review
  • Scope of the PRs (smaller, focused)
  • Giving feedback
  • Receiving feedback (closing the comments with a check, etc)
  • Reviewing even when not directly added
  • Closing the branch? Keeping the branch?
@skulptur skulptur self-assigned this Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant