Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable the @typescript-eslint/dot-notation rule in favor of the noPropertyAccessFromIndexSignature TypeScript option #252

Open
leroykorterink opened this issue Apr 22, 2024 · 1 comment
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@leroykorterink
Copy link
Collaborator

The noPropertyAccessFromIndexSignature TypeScript option conflicts with @typescript-eslint/dot-notation. TypeScript options should take precedence, this means that we should disable the @typescript-eslint/dot-notation rule.

image
image

@leroykorterink leroykorterink added bug Something isn't working good first issue Good for newcomers labels Apr 22, 2024
@ThaNarie
Copy link
Member

Not sure if I like the TS rule though :(

The rule itself does make sense (https://www.typescriptlang.org/tsconfig#noPropertyAccessFromIndexSignature) in that it reflects the type system properly, but it doesn't align with how we want to write JS in most cases (using ['key] syntax only when using dynamic keys from variables).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants