Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Doubleclick/Workspace Upload - Try to remove dependency on puppeteer #1

Open
mirkovw opened this issue Jan 27, 2022 · 1 comment
Open

Doubleclick/Workspace Upload - Try to remove dependency on puppeteer #1

mirkovw opened this issue Jan 27, 2022 · 1 comment
Assignees
@mirkovw @PabloCarreira
Labels
enhancement New feature or request

Comments

@mirkovw
Copy link
Contributor

mirkovw commented Jan 27, 2022 •
edited
Loading

display-upload/src/util/Doubleclick.js

Line 3 in a379577

const puppeteer = require('puppeteer');

display-upload/src/util/Workspace.js

Line 4 in a379577

const puppeteer = require('puppeteer');

This will greatly reduce installation time of the boilerplate
@mirkovw mirkovw added the enhancement New feature or request label Jan 27, 2022
@mirkovw mirkovw self-assigned this Jan 27, 2022
@mirkovw
Copy link
Contributor Author

mirkovw commented Jan 27, 2022

Potentially we can use OAuth2 for authentication in requests

@mirkovw mirkovw changed the title Doubleclick Upload - Try to remove dependency on puppeteer Doubleclick/Workspace Upload - Try to remove dependency on puppeteer Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirkovw mirkovw

@PabloCarreira PabloCarreira

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mirkovw @PabloCarreira