qutil improvements #361
Open
qutil improvements #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix mediacloud#355 by only dumping x-mc- headers (as noted in comments) Add --really-queue and --ignore-domain options
pgulley
approved these changes
Dec 26, 2024
|
@pgulley without the option it's a "dry run" (tests whether the file is valid). I wanted to be able to test whether the file was valid before committing to actually queuing it (and encourage that behavior). TOTALLY open to better naming!!! |
|
Calling the flag '--dry-run,' or '--test-run,' and defaulting it to true feels less convoluted to me, as long as there's a comment in the help message explaining that flipping it to false is necessary to actually queue |
|
A humorous contranym for --dry-run would be --wet-run!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #355 by only dumping x-mc- headers (as noted in comments)
Add --really-queue and --ignore-domain options