-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only static text as caption? #56
Comments
Hi @raba34, could you please provide a sample GGB file and some screenshots to exactly describe what you are trying to achieve? Thanks in advance! |
Hello, I have attached four screenshots. The first two images show the normal error-free behavior. Images 3 and 4 show what happens when you use a separate text for the label. In image 1 you can see how a static text is created as a label for the boolean variable. In image2 you can see that the label is displayed correctly in the GeoGebra task in Moodle. In image 3, the label is first created as a separate text. In image 4 you can see that the label is not displayed. The GGB file (Punkte2.ggb) for image 3 can be found at |
Your .ggb file is using "text as caption" on Please provide a .ggb file showing the problem you originally describe with %c |
Could it be that there is a misunderstanding here? With the "moodle-qtype_geogebra" it is necessary to label the boolean variables. This label is used for the feedback as text. This is how this task type is constructed. As you can see in image 1 and in image 2 it works for static text too. Before I document the more complicated case "%c", let's first discuss the simpler case I have shown in Image 3 and 4. |
Please send the .ggb file for %c |
I send you the GBB file and the result in qtype geogebra.
As you can see, the boolean variable A1 is correctly taken from the
spreadsheet. But instead of "Hello" it says "%c". So the substitution
was not done.
Am 24.05.2022 12:28, schrieb Michael Borcherds:
Please send the .ggb file for %c
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Sorry, I don't see the .ggb file |
Perhaps it is better with this link:
https://oszlisemeitner-my.sharepoint.com/:u:/g/personal/ba_osz-lise-meitner_eu/EQqDMz-xxLBBr4miOeip4-gBRSeTtBRYwFDYnAK7k6w9AA?e=O1CiPf
Am 24.05.2022 13:34, schrieb Michael Borcherds:
Sorry, I don't see the .ggb file
--
Reply to this email directly, view it on GitHub [1], or unsubscribe
[2].
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Thanks, I've had a look and the API call ggbApplet.getCaption() returns just the "raw" caption ie what the user has typed in the Caption textfield so ggbApplet.getCaption("A1") returns "%c" and the "Use text as caption" doesn't affect what ggbApplet.getCaption() returns (as you've noticed) so you won't be able to use those features |
So my guess is correct: only the exact text that is entered directly at the label is output. So neither the replacements like %c nor the possibility to specify the value of a text variable works. If this is true, then the only feedback is: "The result is correct." if the variable is true, and no feedback if the variable is false. But this is very inflexible. Aren't there other ways to make the feedback more flexible? |
OK, as far as I can tell: the The issue here is probably that I think we can adress this while doing the rework. @murkle Can you confirm I got this right? |
Ah, good spot! Yes, using getCaption() should fix the %c issue at least 😄 What else is being extracted directly from XML? |
Not 100% sure if there are other places where XML is being read. Having a first look it does not seem to be used in other places, at least not in the JS code. I'm not sure, why the feedback is being extracted with a XML parser (which didn't even work in all cases, see the fix #54 which has recently been merged). Maybe the In general: If there is an API function IMHO we should use it, the target is to remove XML as a data structure completely anyway for this plugin and just rely on base64, see #55 . |
Since I don't understand the programming details, I wanted to ask if this activity here indicates that the fixes are being addressed and a result can be expected soon. |
The issue concerning the placeholders can and will be adressed most likely. If it will be possible to also deal with the associated text labels as caption instead of the description itself, I can't tell right now. However, the way we extract these information will have to be completely rewritten to make this work. We plan to rework a lot of the code in this plugin anyway. While doing so we will try to adress these issues as well. So the answer would be "Yes, we will adress this", but this will take some time until it will make it into a production ready version of this plugin, sorry. |
I find it very pleasing that finally someone cares more intensively about this plugin. Many thanks for that! But if I understand correctly, it's only about replacing %c, %v and %n. %x, %y and %z don't make sense here, do they? |
I can only assume right now, but the idea is to use the GeoGebra internal function to retrieve the caption which should ideally deal with all the possible placeholders in GeoGebra. If this is working out the way I imagine we should be able to support the captions like GeoGebra does, because we basically use the exact same function. |
Hello,
In geo1.jpg you can see how a static text is created as a label for the
boolean variable. In geo2.jpg you can see that the label is displayed
correctly in the GeoGebra task in Moodle.
In geo3.jpg, the label is first created as a separate text. In geo4.jpg
you can see that the label is not displayed.
I have also attached the GGB file belonging to geo3.jpg.
Best regards,
Ralph
Am 23.05.2022 17:00, schrieb PhMemmel:
Hi @raba34 [1],
could you please provide a sample GGB file and some screenshots to
exactly describe what you are trying to achieve? Thanks in advance!
--
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Could you please also add the pictures you are referring to? Github probably does not add mail attachments when replying via mail. You probably need to use the github issue tracker via browser directly. |
Hi @PhMemmel , it is a pleasant surprise to receive feedback after almost five months. Since I delete very little in the "Download" directory, the four files mentioned are actually still there. I attach them to this message. Best Regards, ================== geo1.jpg ========================================================= ================== geo2.jpg ========================================================= ================== geo3.jpg ========================================================= ================== geo4.jpg ========================================================= ================================================================================== |
Thank you for the screenshots. The issue is quite clear now. Unfortunately, there are a lot of things with higher priority on our list and we will only be able to tackle this issue while going for a bigger rework which will take some time, sorry. |
Hello,
it looks like you can only enter static text as caption.
"Use text as caption" has no effect.
Also the placeholder %c has no effect. I had written the boolean variables in a table column and right next to it in the next column the text. Unfortunately also no effect. It simply appears "%c" in the field of the variables.
Ralph
The text was updated successfully, but these errors were encountered: